Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last live date #104

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

caseycesari
Copy link
Contributor

@caseycesari caseycesari commented Aug 1, 2019

Overview

The previous date caused the API to return a 403. It is not clear why, but having a more recent date does not cause the same issue.

Connects #103

Notes

This is considered a quick fix to get live data back in the app. Budget permitting, we may need a more dynamic way to detect that last live date. See #68

Testing Instructions

  • Verify all of the sensor API requests succeed and the sensor data is from today.

@fungjj92
Copy link
Contributor

fungjj92 commented Aug 2, 2019

Hm this strikes me as odd. I checked all the API calls using the requests made on develop and I got 403 on the first request or two. After a few refreshes, the calls worked and I received data. Could that be the issue, rather than the date in the query?

In any case, I think we can update both sets of dates. It looks like all the sensors have data updates as of 8/2/2019 aka today?

@caseycesari
Copy link
Contributor Author

Hm this strikes me as odd. I checked all the API calls using the requests made on develop and I got 403 on the first request or two. After a few refreshes, the calls worked and I received data. Could that be the issue, rather than the date in the query?

I also noticed this behavior in the browser, but the app consistently failed. Using a more current date for that parameter never failed within the app or browser. I think this is some sort of bug on their end.

The previous date caused the API to return a 403. It is not clear why,
but having a more recent date does not cause the same issue.

Refs #103
@caseycesari caseycesari force-pushed the cpc/update-last-live-sensor-date branch from 0c08a99 to 0796538 Compare August 2, 2019 18:52
@caseycesari
Copy link
Contributor Author

Good call on updating the quarterly date. Pushed up an updated commit to do that.

Copy link
Contributor

@fungjj92 fungjj92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great!

@fungjj92 fungjj92 assigned caseycesari and unassigned fungjj92 Aug 2, 2019
@caseycesari
Copy link
Contributor Author

Thanks!

@caseycesari caseycesari merged commit 35012a5 into develop Aug 5, 2019
@caseycesari caseycesari deleted the cpc/update-last-live-sensor-date branch August 5, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants