Show icons for nonempty search #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2019 17:41
Update the logic of the appactions rendering to have the map action, help action and authenticated actions menu display when the search box is not expanded but does have a search term in it.
Cool, thanks for making that -- and for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a bug in the Unity Bar whereby the map, help, and authentication action icons wouldn't display when the search box had a term entered in it. They'll still be hidden when the search box is expanded, but will return when the input loses focus.
Connects #70
Connects https://github.com/azavea/pwd-parcel-viewer/issues/719
Demo
Notes
First commit fixes part of an npm audit encountered issue with the tar package. We can't fully fix it yet because it's also a dependency of node-sass, which hasn't been updated since the issue was reported.
Testing Instructions