Enable hiding apps in app switcher #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2019 10:59
Add props which host applications can use to toggle which links to other PWD apps are displayed in the app switcher. This enables using the UnityBar in applications which have been deployed while the others have not yet been deployed.
|
Looking at this now. |
kellyi
force-pushed
the
ki/enable-hiding-apps-in-app-switcher
branch
from
753c748 to
5b977f6
Compare
|
Browsing https://5cc331cf1e070e000c24e9ba--staging-pwd-unitybar.netlify.com/ I can't scroll the page in Chrome, Safari, or Firefox. In all screen captures I am scrolling up and down with my trackpad. Chrome
Safari
Firefox
|
jwalgran
reviewed
Apr 26, 2019
kellyi
force-pushed
the
ki/enable-hiding-apps-in-app-switcher
branch
from
5b977f6 to
9bcf5ca
Compare
|
Thanks for catching that. I'm just going to drop the demo app scroll changes related to #81 for now as they are not important for making the Unity Bar release. I pushed an amended commit and will update the testing instructions. |
jwalgran
approved these changes
Apr 26, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enables hiding specific apps from the app switcher menu so that we can use the Unity Bar in applications which have been deployed while other applications have not been deployed.
First commit here fixes an issue via npm audit fix.
Connects #83
Demo
Notes
I intentionally did not attempt to change the width or of the App Switcher when not all of the apps are visible. If it becomes desirable to do that in the future -- for instance, if there's a long interval between the PV deployment and GARP deployment -- then we can handle it in another issue.
Testing Instructions