Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Fairmount Water Works quest and zones. #48

Merged
merged 1 commit into from
May 6, 2015
Merged

Add new Fairmount Water Works quest and zones. #48

merged 1 commit into from
May 6, 2015

Conversation

caseycesari
Copy link
Contributor

  • Add new content from Victoria. This process involved converting
    tif files to jpegs, reworking the directory structure to be a bit
    simpler and to avoid folders with spaces in the names, and adding
    a json file to each zone that contains configuration and image
    metadata for that zone. Image names were left as-is. There are some
    images that weren't used in the storyboards document, but I checked
    them in anyway in case we need to add them later.
  • Ignore .tif. This allows us to keep the original files (.tifs)
    next to the jpeg files that we are using in case we need to generate
    new images from the originals.
  • Tell git not to try and parse image files to create a diff. This
    ruins the images.

Connects to #35

A couple things to note:

  • The images are generally named in the order they should be displayed, but there are exceptions. Therefore I think we should use the order they are listed in each zone.json for display order.
  • Zone J has a Zone O nested inside of it. I wasn't sure how to handle this, so I made it a separate zone and gave it a fake location. I created Handle nested zones #46 to determine how to handle this.
  • We'll need to support loading video too. Support playing video in zone #47

@lliss I'm not sure if you started #34, but there are two changes from the sample I created.

  • The directory name in quests for this set of zones is now fairmount-water-works instead of fairmount-waterworks.
  • In zone.json, primaryPhotos and secondaryPhotos are now primaryItems and secondaryItems since we know that we'll be display video in one of them.

* Add new content from Victoria. This process involved converting
tif files to jpegs, reworking the directory structure to be a bit
simpler and to avoid folders with spaces in the names, and adding
a json file to each zone that contains configuration and image
metadata for that zone. Image names were left as-is. There are some
images that weren't used in the storyboards document, but I checked
them in anyway in case we need to add them later.
* Ignore *.tif. This allows us to keep the original files (*.tifs)
next to the jpeg files that we are using in case we need to generate
new images from the originals.
* Tell git not to try and parse image files to create a diff. This
ruins the images.

Connects to #35
@caseycesari
Copy link
Contributor Author

Not a great way to test this, but maybe take a look at the storyboard document and check a couple zone.json files.

@caseycesari
Copy link
Contributor Author

Also, I didn't remove any of the old stuff. We should only remove once the new stuff is wired up in #34.

@lliss
Copy link
Contributor

lliss commented May 5, 2015

+1
Structure looks good. Spot checked a few zones and verified that the json is all valid.

@lliss lliss assigned caseycesari and unassigned lliss May 5, 2015
caseycesari pushed a commit that referenced this pull request May 6, 2015
Add new Fairmount Water Works quest and zones.
@caseycesari caseycesari merged commit 89b9033 into azavea:master May 6, 2015
@caseycesari caseycesari deleted the feature/content-package branch May 6, 2015 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants