-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetReactState to CreatureMethods and GetKnownTaxiNodes, SetKnownTaxiNodes to PlayerMethods #260
base: master
Are you sure you want to change the base?
Conversation
Also added GetKnownTaxiNodes and SetKnownTaxiNodes to PlayerMethods. All 3 functions have been tested by me and are currently in use in a couple of scripts utilizing Eluna. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for merging it in. It says it was merged into master but I'm not seeing it in the list of recent commits. It looks like the "merge branch 'master' into master went into the fork instead of the repo here. Is that something I did wrong, or there anything else I need to do?
Side note: still a rookie when it comes to these, so I do apologize. I'll make sure any future commits get added into a separate branch so that way it's not pulling straight from master.
I've merged recent changes FROM master into this PR to see if the build is ok. The PR wasn't merged into master yet, but i plan to when the build is green. |
The LuaJit build keeps failing here. |
Is there anything I need to do? |
Looks like this requires an #IFDEF block. |
lua_rawlen is mapped to lua_objlen #define lua_rawlen(L, idx) \ lua_objlen(L, idx)
Looks like it is green now :) |
Let me know if anything else is needed here. |
We have the ability to SetReactState, but we don't have to ability to GetReactState.