Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXE-5886] refactor: update WAF rules create service to use API v4 endpoint #2008

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

peterpaulo-azion
Copy link
Contributor

@peterpaulo-azion peterpaulo-azion commented Dec 11, 2024

Pull Request

What is the new behavior introduced by this PR?

  • Renamed makeWafBaseUrl to makeWafRulesBaseUrl for clarity.
  • Updated service files to use the new base URL function.
  • Adjusted the createWafRulesService import in the routes file to align with the new structure.
  • Ensured all relevant services are exported from the index file.

Does this PR introduce breaking changes?

  • No
  • Yes

Does this PR introduce UI changes? Add a video or screenshots here.

Does it have a link on Figma?


Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] TYPE: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@peterpaulo-azion peterpaulo-azion self-assigned this Dec 11, 2024
@peterpaulo-azion peterpaulo-azion requested review from a team as code owners December 11, 2024 07:41
@peterpaulo-azion peterpaulo-azion changed the title [UXE-5886] feat: migrated edge firewall delete function to api v4 [UXE-5886] refactor: update WAF rules create service to use API v4 endpoint Dec 11, 2024
pauloSF0
pauloSF0 previously approved these changes Dec 11, 2024
lucasmendes21
lucasmendes21 previously approved these changes Dec 11, 2024
HerbertJulio
HerbertJulio previously approved these changes Dec 11, 2024
@peterpaulo-azion peterpaulo-azion changed the base branch from freezing to dev December 11, 2024 13:00
@peterpaulo-azion peterpaulo-azion dismissed stale reviews from HerbertJulio, lucasmendes21, aloisio-m-bastian, and pauloSF0 December 11, 2024 13:00

The base branch was changed.

@peterpaulo-azion
Copy link
Contributor Author

PR #2011 - já aprovado e adicionado a esse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants