-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UXE-5886] refactor: update WAF rules create service to use API v4 endpoint #2008
Open
peterpaulo-azion
wants to merge
11
commits into
dev
Choose a base branch
from
uxe-5886-waf-create-v4
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+292
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7cc9584.
peterpaulo-azion
changed the title
[UXE-5886] feat: migrated edge firewall delete function to api v4
[UXE-5886] refactor: update WAF rules create service to use API v4 endpoint
Dec 11, 2024
pauloSF0
previously approved these changes
Dec 11, 2024
aloisio-m-bastian
previously approved these changes
Dec 11, 2024
lucasmendes21
previously approved these changes
Dec 11, 2024
HerbertJulio
previously approved these changes
Dec 11, 2024
peterpaulo-azion
dismissed stale reviews from HerbertJulio, lucasmendes21, aloisio-m-bastian, and pauloSF0
December 11, 2024 13:00
The base branch was changed.
PR #2011 - já aprovado e adicionado a esse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What is the new behavior introduced by this PR?
makeWafBaseUrl
tomakeWafRulesBaseUrl
for clarity.createWafRulesService
import in the routes file to align with the new structure.Does this PR introduce breaking changes?
Does this PR introduce UI changes? Add a video or screenshots here.
Does it have a link on Figma?
Checklist
Make sure your pull request fits the checklist below (when applicable):
These changes were tested on the following browsers: