[UXE-5763] feat: migrate edge dns zone creation to api v4 #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauloSF0
previously approved these changes
Jan 28, 2025
|
Aloísio preciso que tu preenchas o template do PR. |
src/services/edge-dns-services/v4/create-edge-dns-zones-service.js
Outdated
Show resolved
Hide resolved
src/services/edge-dns-services/v4/create-edge-dns-zones-service.js
Outdated
Show resolved
Hide resolved
lucasmendes21
approved these changes
Feb 3, 2025
HerbertJulio
approved these changes
Feb 3, 2025
| @@ -29,7 +29,7 @@ describe('Edge DNS spec', { tags: ['@dev5', '@dont_run_prod'] }, () => { | |||
| cy.get(selectors.edgeDns.nameInput).type(zoneName) | |||
| cy.get(selectors.edgeDns.domainInput).type(`${zoneName}.com.az`) | |||
| cy.get(selectors.edgeDns.saveButton).click() | |||
| cy.verifyToast('success', 'Your Edge DNS has been created') | |||
| cy.verifyToast('success', 'Your Edge DNS Zonehas been created') | |||
There was a problem hiding this comment.
Suggested change
| cy.verifyToast('success', 'Your Edge DNS Zonehas been created') | |
| cy.verifyToast('success', 'Your Edge DNS Zone has been created') |
There was a problem hiding this comment.
Obrigado por apontar, graças a esse assert percebi que os testes não estão sendo executados nas actions da PR. Isso será tratado posteriormente na issue: https://aziontech.atlassian.net/browse/UXE-6264
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What is the new behavior introduced by this PR?
migrate edge dns zone creation to api v4
Does this PR introduce breaking changes?
Does this PR introduce UI changes? Add a video or screenshots here.
Does it have a link on Figma?
Checklist
Make sure your pull request fits the checklist below (when applicable):
These changes were tested on the following browsers: