Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦️ Remove scipy dependency #59

Merged
merged 4 commits into from
Apr 8, 2024
Merged

📦️ Remove scipy dependency #59

merged 4 commits into from
Apr 8, 2024

Conversation

azogue
Copy link
Owner

@azogue azogue commented Apr 8, 2024

Follow up #58, this time removing scipy dependency, as it was an overkill for the usages here.

Changes
  • ⚡️ Use simple 1D interpolator to project points instead of scipy.interpolate.interp1d
  • ✅ Add tests for convex hulls of given points
  • ⚡️ Use simple convex hull algorithm, to compute zones to group annotated points, instead of using scipy.spatial.ConvexHull
  • 📦️ Bump version, removing scipy dependency

Copy link

github-actions bot commented Apr 8, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1330 1330 100% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
psychrochart/chartdata.py 100% 🟢
psychrochart/plot_logic.py 100% 🟢
psychrochart/process_logic.py 100% 🟢
psychrochart/util.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 24e15d1 by action🐍

@azogue azogue merged commit d4d1026 into master Apr 8, 2024
2 checks passed
@azogue azogue deleted the remove-scipy-dependency branch April 8, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant