-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FakeNavigationManager): Do Not set Uri if navigation is prevented… #1649
fix(FakeNavigationManager): Do Not set Uri if navigation is prevented… #1649
Conversation
… on net7.0 or greater
@microsoft-github-policy-service agree |
src/bunit.web/TestDoubles/NavigationManager/FakeNavigationManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, could you add an entry to the CHANGELOG.md
file?
This is used for our release notes. You can add a new ### Fixed
section under ## UNRELEASED
Sure thing, does the bUnit team want PR's rebased down to a single commit or changes from feedback added as additional commits? |
We will squash the commits into a single commit anyway. So feel free to do what you feel most comfortable with. |
…i on prevention; updating test case to match.
tests/bunit.web.tests/TestDoubles/NavigationManager/FakeNavigationManagerTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Steven Giesel <[email protected]>
Nice one @ayyron-dev ! Will merge soon |
… on net7.0 or greater
Pull request description
This PR is meant to address issue #1647
NavigationManager has added functionality to support preventing navigation in net7.0 and later so this PR updates teh FakeNavigationManager to not set the Uri property with the target uri if navigation was prevented by the user.
PR meta checklist
main
branch for codeor targeted at
stable
branch for documentation that is live on bunit.dev.Code PR specific checklist