Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FakeNavigationManager): Do Not set Uri if navigation is prevented… #1649

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

ayyron-dev
Copy link
Contributor

@ayyron-dev ayyron-dev commented Jan 14, 2025

… on net7.0 or greater

Pull request description

This PR is meant to address issue #1647

NavigationManager has added functionality to support preventing navigation in net7.0 and later so this PR updates teh FakeNavigationManager to not set the Uri property with the target uri if navigation was prevented by the user.

PR meta checklist

  • Pull request is targeted at main branch for code
    or targeted at stable branch for documentation that is live on bunit.dev.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@ayyron-dev
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Collaborator

@linkdotnet linkdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, could you add an entry to the CHANGELOG.md file?

This is used for our release notes. You can add a new ### Fixed section under ## UNRELEASED

@ayyron-dev
Copy link
Contributor Author

Additionally, could you add an entry to the CHANGELOG.md file?

This is used for our release notes. You can add a new ### Fixed section under ## UNRELEASED

Additionally, could you add an entry to the CHANGELOG.md file?

This is used for our release notes. You can add a new ### Fixed section under ## UNRELEASED

Sure thing, does the bUnit team want PR's rebased down to a single commit or changes from feedback added as additional commits?

@linkdotnet
Copy link
Collaborator

Additionally, could you add an entry to the CHANGELOG.md file?
This is used for our release notes. You can add a new ### Fixed section under ## UNRELEASED

Additionally, could you add an entry to the CHANGELOG.md file?
This is used for our release notes. You can add a new ### Fixed section under ## UNRELEASED

Sure thing, does the bUnit team want PR's rebased down to a single commit or changes from feedback added as additional commits?

We will squash the commits into a single commit anyway. So feel free to do what you feel most comfortable with.

CHANGELOG.md Outdated Show resolved Hide resolved
@linkdotnet
Copy link
Collaborator

Nice one @ayyron-dev !

Will merge soon

@linkdotnet linkdotnet enabled auto-merge (squash) January 16, 2025 16:01
@linkdotnet linkdotnet disabled auto-merge January 16, 2025 16:02
@linkdotnet linkdotnet merged commit 2284ed6 into bUnit-dev:main Jan 16, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants