Fix formatting issue in CAST MONEY to CHAR/VARCHAR

[rishabhtanwar29]

Description

While CASTing money/smallmoney to (N)VARCHAR/(N)CHAR, the value get rounded
to 4 decimal places instead of 2. Fixed this by implementing CASTs from money to
CHAR/VARCHAR datatype which rounds off input money value to 2 decimal places and
converts it to string.

Additionally, while CASTing money values to (N)CHAR, the resultant string gets left padded
instead of usual right padding. This commit also fixes this issue.

Task: BABEL-5478
Signed-off-by: Rishabh Tanwar [email protected]

Test Scenarios Covered

• Use case based -
  test_conv_money_to_varchar-vu-*

• Boundary conditions -

• Arbitrary inputs -

• Negative test cases -

• Minor version upgrade tests -

• Major version upgrade tests -

• Performance tests -

• Tooling impact -

• Client tests -

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coveralls]

Pull Request Test Coverage Report for Build 12669687424

Details

• 78 of 89 (87.64%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 74.92%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contrib/babelfishpg_common/src/varchar.c	78	89	87.64%

Totals
Change from base Build 12667158541:	0.02%
Covered Lines:	46750
Relevant Lines:	62400

---

💛 - Coveralls