This repository was archived by the owner on Oct 15, 2024. It is now read-only.
feat: v3 unbalanced removes #1154
Merged
+652
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethfuller
reviewed
Oct 8, 2024
lib/shared/labels.ts
Outdated
Comment on lines
6
to
10
| // Converts an index to a letter. 0 is A, 1 is B, etc. | ||
| export function indexToLetter(index: number): string { | ||
| if (index >= 0 && index <= 25) return String.fromCharCode(index + 65) | ||
| throw new Error('index but be between 0 and 25') | ||
| } |
There was a problem hiding this comment.
Why is this function needed?
There was a problem hiding this comment.
It is used in the Step Tracker to show A, B, C in the sub steps here:
garethfuller
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds v3 removes using standard permit signatures
Works for
ProportionalandSingle tokenremovesExample of Proportional remove (using sepolia pool in test api):