Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

feat: show LP tokens in add form details #1156

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

agualis
Copy link
Contributor

@agualis agualis commented Oct 9, 2024

LPtokens

Example use case:
Trying to see how much veBAL I would get depositing vs. swapping.

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 9:47am
test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 9:47am

Copy link
Contributor

@uiuxxx uiuxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@garethfuller garethfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of any cases where this might cause problems? e.g. if approvals have not been done? Is there not a case where simulations fail until approvals are in place?

@agualis
Copy link
Contributor Author

agualis commented Oct 9, 2024

Can you think of any cases where this might cause problems? e.g. if approvals have not been done? Is there not a case where simulations fail until approvals are in place?

Good point. I don't think we have that problem in add simulations.

However, I realised that pools requiring proportional inputs are not showing this LP tokens field as these pools do not display price impact details:

Screenshot 2024-10-09 at 12 40 33

@garethfuller @uiuxxx Are you fine with this drawback? Or do you prefer to add a UI workaround/redesign this?

@garethfuller
Copy link
Contributor

@agualis I think it's fine to leave this as it is for now. If this feature is needed on CoW pools we can do that in another PR when requested.

@agualis agualis merged commit c9b55e2 into main Oct 9, 2024
7 checks passed
@agualis agualis deleted the feat/LPTokensInDetails branch October 9, 2024 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants