This repository was archived by the owner on Oct 15, 2024. It is now read-only.
feat v3 proportional adds/removes #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
agualis
commented
Oct 10, 2024
| return signature | ||
| } | ||
|
|
||
| // Instead of MaxAllowanceTransferAmount(MaxUint160) we use MaxUint159 to avoid overflow issues | ||
| const MaxUint159 = BigInt('0x7fffffffffffffffffffffffffffffffffffffff') |
There was a problem hiding this comment.
@garethfuller I found problems when using MaxAllowanceTransferAmount (MaxUint160) in the b-sdk. Using 159 works but I will check with the SDK team to discard related bugs.
There was a problem hiding this comment.
Ok, yeah please check with SDK team. Where did you get the solution to use 159?
garethfuller
approved these changes
Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some v3 pools (the ones with
disableUnbalancedLiquidityproperty) require proportional token adds/removes.Important note
Note that this pool has low liquidity and it will fail if you try to add amounts bigger than 1-2 USD.
@groninge01 will replicate the removes feature to disable >25% adds soon. We'll have to test that feature with proportional adds too.
For now we only have this SEPOLIA example (only in
test-api):pools/sepolia/v3/0x8fc07bcf9b88ace84c7523248dc4a85f638c9536/Add example:
https://github.com/user-attachments/assets/1f00cd63-9405-4be3-933c-abc36ea32888
Remove example:
https://github.com/user-attachments/assets/91ff5711-6dd5-4b94-850a-95837068674f