Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes sails.models and sails.adapters references #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinjlowm
Copy link

The ORM hook would override any models and adapters that were loaded before it and, prior to this change, other hooks would have to load models and adapters when orm-hook-loaded is emitted. Any hooks that utilize Marlinspike [1] might not work at all, because it loads controllers, models, etc. on configure rather than on initialize and after orm-hook-loaded.

This change was tested on 1.0.0-42 of Sails and it enables models and adapters to be loaded on configure.

[1] https://github.com/tjwebb/marlinspike

@luislobo
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants