Add samples from camel pages #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayeshLK
reviewed
Jun 14, 2023
| string content; | ||
| }; | ||
|
|
||
| Blog[] blogs = []; |
There was a problem hiding this comment.
Suggested change
| Blog[] blogs = []; | |
| isolated Blog[] blogs = []; |
|
|
||
| configurable string slackToken = ?; | ||
|
|
||
| type Blog record { |
There was a problem hiding this comment.
Suggested change
| type Blog record { | |
| type Blog record & readonly { |
| Blog[] blogs = []; | ||
|
|
||
| service /blog on new http:Listener(9090) { | ||
| slack:Client slackClient; |
There was a problem hiding this comment.
Suggested change
| slack:Client slackClient; | |
| final slack:Client slackClient; |
| }; | ||
| _ = check self.slackClient->postMessage(messageParams); | ||
| } | ||
| } |
| @@ -0,0 +1,42 @@ | |||
| import ballerina/http; | |||
|
|
||
| listener http:Listener helloEP = new(9090); | ||
|
|
||
| type Item record { |
There was a problem hiding this comment.
Suggested change
| type Item record { | |
| type Item record & readonly { |
Comment on lines
+14
to
+18
| configurable string host = ?; | ||
| configurable int port = ?; | ||
| configurable string user = ?; | ||
| configurable string password = ?; | ||
| configurable string database = ?; |
There was a problem hiding this comment.
Can't we make a configuration record and use it ? Check the following code sample.
ayeshLK
reviewed
Jun 14, 2023
| }); | ||
|
|
||
| service on orderListener { | ||
| private final kafka:Producer orderProducer; |
There was a problem hiding this comment.
When declaring client inside a service, shall we follow a consistent approach ? (check for other places you have declared db-client, slack-client etc.)
| topics: "payment_completed_topic" | ||
| }); | ||
|
|
||
| map<int> inventory = { |
There was a problem hiding this comment.
Suggested change
| map<int> inventory = { | |
| isolated map<int> inventory = { |
| import ballerinax/kafka; | ||
| import wso2/orders.types; | ||
|
|
||
| map<types:Order> ordersStore = {}; |
There was a problem hiding this comment.
Suggested change
| map<types:Order> ordersStore = {}; | |
| isolated map<types:Order> ordersStore = {}; |
| @@ -0,0 +1,36 @@ | |||
| public type OrderRequest record {| | |||
There was a problem hiding this comment.
Shall we mark the types as readonly ?
Suggested change
| public type OrderRequest record {| | |
| public type OrderRequest record & readonly {| |
| org = "wso2" | ||
| name = "orders.types" | ||
| version = "0.1.0" | ||
| repository = "local" |
There was a problem hiding this comment.
Suggested change
| repository = "local" | |
| repository = "local" | |
|
|
||
| foreach types:Order 'order in orders { | ||
| types:PaymentDetails paymentDetails = 'order.paymentDetails; | ||
| if (isPaymentValid(paymentDetails)) { |
There was a problem hiding this comment.
Suggested change
| if (isPaymentValid(paymentDetails)) { | |
| if isPaymentValid(paymentDetails) { |
| maxTemp: day.maxtemp_c, | ||
| minTemp: day.mintemp_c | ||
| }; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$Subject
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning