Add Docker flag to remove containers after finishing #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `DockerRun.sh` stale containers were left over after closing the application. These containers would also not be re-used. Add the `--rm` flag to make Docker delete the containers after running the application, since they are re-created for each run anyways.
MackBambu
approved these changes
Aug 8, 2024
|
@MackBambu Thank you for the approval. It seems the workflow run is still waiting an approval. Is there any further action I need to take for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
DockerRun.shstale containers were left over after closing the application. These containers would also not be re-used.Add the
--rmflag to make Docker delete the containers after running the application, since they are re-created for each run anyways.