feat: Allow Velero container creation #26
Conversation
tanmay-pnaik
requested review from
bonifaido,
akijakya and
sagikazarmark
as code owners
|
Great work @tanmay-pnaik, would you mind rebasing with latest changes? |
Done! |
Hi @tanmay-pnaik, sorry for the inconvenience but merge commits are not allowed on feature branches, could you please remove those and rebase onto main instead? Thanks! |
|
Can we also move the templates into a separate PR? |
Signed-off-by: Tanmay Pereira Naik <[email protected]>
tanmay-pnaik
force-pushed
the
feat/velero
branch
from
7db2957 to
be7b79e
Compare
Done! |
Done, see #33 |
There was a problem hiding this comment.
Thanks for the feature addition, but I do have to note something here:
I think we already have a way to enable support for Velero via:
.Values.podAnnotations- we can use to inject Velero hook annotations.Values.extraContainers- we can use to add Velero container
I would suggest using these two fields to add this functionality. Therefore, rather than extending the helm chart, perhaps you could document this in the chart readme. Let me know if this would work for you.
|
@tanmay-pnaik If it's okay with you, we can close this one. I created #83 to track the other issue. Sorry for the hassle :( |
Allow Velero container creation without the use of CRDs
Referred to config at https://github.com/bank-vaults/vault-operator/blob/main/pkg/controller/vault/vault_controller.go