Skip to content

Commit

Permalink
Copilot Chat deployment: Add sk probe endpoint to deployment output (m…
Browse files Browse the repository at this point in the history
…icrosoft#1340)

### Motivation and Context
After [deploying Copilot Chat to
Azure](https://learn.microsoft.com/en-us/semantic-kernel/deploy/deploy-to-azure),
the default behavior of users is to access the [`endpoint`
url](https://github.com/microsoft/semantic-kernel/blob/main/samples/apps/copilot-chat-app/webapi/DeploymentTemplates/sk-new.bicep#LL60C1-L60C1)
from the Deployment Output. However, this URL results in 404 (since the
user has to append `/probe`) to the URI. It would be great to have that
`probe` URI as part of the Deployment output, in case users miss the
[instruction
](https://learn.microsoft.com/en-us/semantic-kernel/deploy/deploy-to-azure#verifying-the-deployment)


![image](https://github.com/microsoft/semantic-kernel/assets/18152044/dcab3052-9c1c-4330-b032-dd709987fe41)

### Description
Add `skProbe` as an output to Deployment outputs.

cc - @glahaye
  • Loading branch information
thegovind authored Jun 5, 2023
1 parent 326d317 commit 134906a
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,4 @@ module semanticKernel 'main.bicep' = {


output endpoint string = semanticKernel.outputs.deployedUrl
output skProbe string = 'https://${semanticKernel.outputs.deployedUrl}/healthz'
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.17.1.54307",
"templateHash": "11779741438695372787"
"templateHash": "10259269086957442877"
}
},
"parameters": {
Expand Down Expand Up @@ -163,7 +163,7 @@
"_generator": {
"name": "bicep",
"version": "0.17.1.54307",
"templateHash": "11121756795286782434"
"templateHash": "1371310943287245701"
}
},
"parameters": {
Expand Down Expand Up @@ -971,6 +971,10 @@
"endpoint": {
"type": "string",
"value": "[reference(resourceId('Microsoft.Resources/deployments', 'SemanticKernel'), '2022-09-01').outputs.deployedUrl.value]"
},
"skProbe": {
"type": "string",
"value": "[format('https://{0}/healthz', reference(resourceId('Microsoft.Resources/deployments', 'SemanticKernel'), '2022-09-01').outputs.deployedUrl.value)]"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,4 @@ module semanticKernel 'main.bicep' = {


output endpoint string = semanticKernel.outputs.deployedUrl
output skProbe string = 'https://${semanticKernel.outputs.deployedUrl}/healthz'
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.17.1.54307",
"templateHash": "697508036669684325"
"templateHash": "2528649938086350051"
}
},
"parameters": {
Expand Down Expand Up @@ -158,7 +158,7 @@
"_generator": {
"name": "bicep",
"version": "0.17.1.54307",
"templateHash": "11121756795286782434"
"templateHash": "1371310943287245701"
}
},
"parameters": {
Expand Down Expand Up @@ -966,6 +966,10 @@
"endpoint": {
"type": "string",
"value": "[reference(resourceId('Microsoft.Resources/deployments', 'SemanticKernel'), '2022-09-01').outputs.deployedUrl.value]"
},
"skProbe": {
"type": "string",
"value": "[format('https://{0}/healthz', reference(resourceId('Microsoft.Resources/deployments', 'SemanticKernel'), '2022-09-01').outputs.deployedUrl.value)]"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,4 @@ module semanticKernel 'main.bicep' = {


output endpoint string = semanticKernel.outputs.deployedUrl
output skProbe string = 'https://${semanticKernel.outputs.deployedUrl}/healthz'
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.17.1.54307",
"templateHash": "3338430546815090156"
"templateHash": "16861206555260857378"
}
},
"parameters": {
Expand Down Expand Up @@ -145,7 +145,7 @@
"_generator": {
"name": "bicep",
"version": "0.17.1.54307",
"templateHash": "11121756795286782434"
"templateHash": "1371310943287245701"
}
},
"parameters": {
Expand Down Expand Up @@ -953,6 +953,10 @@
"endpoint": {
"type": "string",
"value": "[reference(resourceId('Microsoft.Resources/deployments', 'SemanticKernel'), '2022-09-01').outputs.deployedUrl.value]"
},
"skProbe": {
"type": "string",
"value": "[format('https://{0}/healthz', reference(resourceId('Microsoft.Resources/deployments', 'SemanticKernel'), '2022-09-01').outputs.deployedUrl.value)]"
}
}
}

0 comments on commit 134906a

Please sign in to comment.