chore: add build annotation

barry-ran · Jan 10, 2025 · 63c7c02 · 63c7c02
1 parent a0d4056
commit 63c7c02
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/QtScrcpy/CMakeLists.txt b/QtScrcpy/CMakeLists.txt
@@ -55,7 +55,8 @@ if (MSVC)
 
     # avoid warning C4819
     #add_compile_options(-source-charset:utf-8)
-    #add_compile_options(/utf-8)
+    # /utf-8 will set source charset and execution charset to utf-8, so we don't need to set source-charset:utf-8
+    add_compile_options(/utf-8)
 
     # ensure we use minimal "windows.h" lib without the crazy min max macros
     add_compile_definitions(NOMINMAX WIN32_LEAN_AND_MEAN)
@@ -264,6 +265,7 @@ endif()
 
 # MacOS
 if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
+    # qt6 need 10.15 or later
     set(CMAKE_OSX_DEPLOYMENT_TARGET "10.15")
 
     # copy bundle file

diff --git a/ci/mac/build_for_mac.sh b/ci/mac/build_for_mac.sh
@@ -58,7 +58,7 @@ fi
 mkdir $build_path
 cd $build_path
 
-cmake_params="-DCMAKE_PREFIX_PATH=$qt_cmake_path -DCMAKE_BUILD_TYPE=$build_mode -DCMAKE_OSX_ARCHITECTURES=x86_64 -D CMAKE_OSX_DEPLOYMENT_TARGET=10.10"
+cmake_params="-DCMAKE_PREFIX_PATH=$qt_cmake_path -DCMAKE_BUILD_TYPE=$build_mode -DCMAKE_OSX_ARCHITECTURES=x86_64"
 cmake $cmake_params ../..
 if [ $? -ne 0 ] ;then
     echo "cmake failed"