Skip to content

Feat/use solidity source #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat/use solidity source #64

wants to merge 1 commit into from

Conversation

patnir
Copy link
Collaborator

@patnir patnir commented May 9, 2025

Description

Uses forge/ foundry to build the contracts
Adds github submodules as for the contract dependencies
Updates our github actions to compile the smart contract code

Testing

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented May 9, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@patnir patnir force-pushed the feat/use-solidity-source branch 3 times, most recently from efc0e9d to 266cbf9 Compare May 12, 2025 21:35
@patnir patnir marked this pull request as ready for review May 12, 2025 21:36
Uses forge/ foundry to build the contracts
Adds github submodules as for the contract dependencies
Updates our github actions to compile the smart contract code
@patnir patnir force-pushed the feat/use-solidity-source branch from 98f3844 to 7c0e539 Compare May 12, 2025 22:37

- name: Build Contracts
run: |
forge build --force

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to use --force here?

@cb-heimdall
Copy link
Collaborator

Review Error for haardikk21 @ 2025-05-14 10:56:41 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants