Skip to content

refactor(reth/dockerfile): Reference tag instead of branch #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

refactor(reth/dockerfile): Reference tag instead of branch #460

merged 1 commit into from
May 12, 2025

Conversation

wbnns
Copy link
Contributor

@wbnns wbnns commented May 9, 2025 •
edited
Loading

Explicitly use git checkout instead of git switch to grab latest tagged release

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented May 9, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns mentioned this pull request May 9, 2025
Closed
@wbnns wbnns changed the title fix(reth/dockerfile): Reference tag instead of branch refactor(reth/dockerfile): Reference tag instead of branch May 9, 2025
@wbnns wbnns marked this pull request as ready for review May 9, 2025 13:33
@wbnns wbnns merged commit e82da83 into main May 12, 2025
9 checks passed
@wbnns wbnns deleted the wbnns/reth-dockerfile-tagged-version branch May 12, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyer9 meyer9 meyer9 approved these changes

Assignees
No one assigned
Labels
base protocol review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbnns @cb-heimdall @meyer9