Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add German translation of "Base is for everyone" on homepage #1291

Closed
wants to merge 4 commits into from

Conversation

derRizzMeister
Copy link

@derRizzMeister derRizzMeister commented Nov 23, 2024

What changed? Why?

  • Add German translation of "Base is for everyone" on homepage
Screenshot 2567-11-23 at 21 54 57
Screen.Recording.2567-11-23.at.22.59.06.mov

fixed merge conflicts (20th Dec 2024):

image

Notes to reviewers

How has it been tested?

Run yarn workspace @app/web dev
Navigate to http://localhost:3000 in your browser
Make sure the slider is working as expected

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:21am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:21am

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 23, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 1/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Copy link

vercel bot commented Nov 23, 2024

@derRizzMeister is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@wbnns
Copy link
Contributor

wbnns commented Dec 6, 2024

@derRizzMeister

Hi there! Thanks for contributing to Base! Could you please resolve the merge conflict?

@wbnns wbnns self-assigned this Dec 6, 2024
@wbnns wbnns added change(s) requested One or more changes have been requested community contribution labels Dec 6, 2024
@derRizzMeister
Copy link
Author

@wbnns Thank you.

I've resolved the conflicts, could you please check again when you have time? Cheers!

@wbnns wbnns removed their assignment Dec 18, 2024
@wbnns wbnns added base translation review To be reviewed by the Base translation team and removed change(s) requested One or more changes have been requested labels Dec 19, 2024
@derRizzMeister
Copy link
Author

@wbnns fixed another merge conflicts here, thank you!

image

Copy link
Contributor

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@derRizzMeister Thanks for contributing and for building on Base 🔵

@wbnns wbnns added the ready for merge Ready for merge, an additional reviewer is needed label Jan 14, 2025
@wbnns
Copy link
Contributor

wbnns commented Jan 17, 2025

@derRizzMeister Hello, apologies, looks like this has a merge conflict again. There are a lot of competing pull requests to add translations to this file.

@wbnns wbnns added change(s) requested One or more changes have been requested and removed ready for merge Ready for merge, an additional reviewer is needed labels Jan 17, 2025
@wbnns wbnns removed the change(s) requested One or more changes have been requested label Jan 25, 2025
@wbnns
Copy link
Contributor

wbnns commented Feb 5, 2025

Adding in #1702

@wbnns wbnns closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base translation review To be reviewed by the Base translation team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants