Skip to content

Improve login flow and fix "Open with browser" UX issue - update ecosystem.json file again #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tapbase
Copy link

@tapbase tapbase commented Apr 26, 2025

What changed? Why?

This PR addresses two issues:
Desktop login/connect issue: Users accessing the app from desktop (e.g., from base.org) can now log in and connect without problems.
"Open with browser" confusion: The button no longer leads to a deadend for users who aren't logged in. It's been updated to avoid misleading behavior and improve clarity.

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • [] docs.base.org
  • [] docs sub-pages

Copy link

vercel bot commented Apr 26, 2025

@tapbase is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 26, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns
Copy link
Contributor

wbnns commented May 8, 2025

@tapbase Hello, please see the readme for steps on Ecosystem additions, this PR does not conform to the requested format. 🙏

@wbnns wbnns closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants