Improved nvim checks #448
Open
Improved nvim checks #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhh
reviewed
May 18, 2025
| @@ -34,5 +34,6 @@ fi | |||
| # Replace desktop launcher with one running inside Alacritty | |||
| if [[ -d ~/.local/share/applications ]]; then | |||
| sudo rm -rf /usr/share/applications/nvim.desktop | |||
| sudo rm -rf /usr/local/share/applications/nvim.desktop | |||
There was a problem hiding this comment.
I don't have this:
ls /usr/local/share/applications/nvim.desktop
"/usr/local/share/applications/nvim.desktop": No such file or directory (os error 2)
There was a problem hiding this comment.
Normally it is not there, but it may be created in case of a new installation of neovim.
|
In the screenshot above, tested on a fresh install of Omakub on Ubuntu 25.04, I ran the Here is a screenshot with the generated file.
I think it could be useful to remove from there too just to be safe. This might also fix #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when I update nvim from Omakub TUI it still regenerates the desktop app from the package.
I think it's okay to remove it.
Also, update nvim theme only if it's actually installed.
This PR implements #443 and cleans the git history from rebase.