Skip to content

Fix web apps installation and uninstallation #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Kasui92
Copy link
Contributor

@Kasui92 Kasui92 commented May 19, 2025

Install and uninstall procedures were not being invoked correctly due to mismatched cases. I normalized following what was done for the other multiple-select chooses.

Fixes #458

@dhh
Copy link
Member

dhh commented May 20, 2025

I can't replicate that problem on 1.3.0. The case matching we're doing now matches the individual words in the array as is.

@Kasui92
Copy link
Contributor Author

Kasui92 commented May 20, 2025

I also encountered this problem on a fresh installation of v1.3.0 on Ubuntu 25.04.

If you try to uninstall from Omakub panel does it remove them?

@dhh
Copy link
Member

dhh commented May 20, 2025

It does. Odd. Let me try in my VM to confirm.

@dhh
Copy link
Member

dhh commented May 20, 2025

I can't replicate it on my VM either. But I did find that we shouldn't be using --no-sandbox as an option for these web app stubs! So will have to cut a point release for that.

But maybe it's a 25.04 issue? I tested on 24.04. Will try 25.04.

@Kasui92
Copy link
Contributor Author

Kasui92 commented May 20, 2025

I'm also trying with Ubuntu 24.04. On Ubuntu 24.10 I had the same problem.

@dhh
Copy link
Member

dhh commented May 20, 2025

Can't replicate on 25.04 either. Can you show me the exact error message you're seeing?

dhh added a commit that referenced this pull request May 20, 2025
@Kasui92
Copy link
Contributor Author

Kasui92 commented May 20, 2025

Ok, I may have figured out the original problem (... and I'm a little ashamed because I followed it too!)

I think the reason is that the choices were not toggled correctly, but just pressed Enter on the Chat GPT option. By doing this, it doesn't actually take any choices and the array in apps is empty.

If I make the selections instead, the case is matched.

Screenshot From 2025-05-20 12-52-57

So, yes... Everything works, the tool was not used correctly (me first, sorry!).

However, instead of composing the array with all the words (so both "Chat" and "GPT"), isn't it better to work with complete labels (so "chat-gpt")?

It could be added the option to go back and a warning message if no option is chosen.

@Kasui92 Kasui92 closed this May 20, 2025
@Kasui92 Kasui92 deleted the fix-webapps branch May 20, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChatGPT web apps isn't searchable by Ulancher or ubuntu app search
2 participants