Skip to content

Feature/allow different delimiters for sed and prettify labels #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

  • allow | delimiter for sed commands
  • use - instead of : in labels

@skovhus
Copy link
Collaborator

skovhus commented Jul 16, 2023

Thanks!

use - instead of : in labels

Curious what the reason behind this change. Is that more standard?

@EmilyGraceSeville7cf
Copy link
Contributor Author

Curious what the reason behind this change. Is that more standard?

This change reflects this comment. Actually there is no standard here AFAIK. You can meet spaces in labels too.

I am thinking about replacing - with spaces. But I don't know whether Vim/Emacs will be okay with such snippets. @Shane-XB-Qian, do you know anything about this? Is it fine to have spaces for snippets used in Vim/Emacs?

@Shane-XB-Qian
Copy link
Contributor

Shane-XB-Qian commented Jul 17, 2023 via email

@EmilyGraceSeville7cf
Copy link
Contributor Author

This PR is closed in favor to #923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants