Jenkins persistent home support via "volumes-from" #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvlasov
force-pushed
the
jenkins-persistant-home
branch
from
409bcf9 to
9a1a7f3
Compare
jbrisbin
reviewed
Jan 10, 2017
| sed -i "s#\${JENKINS_CONFIG_REPO}#$JENKINS_CONFIG_REPO#g" $JENKINS_HOME/scm-sync-configuration.xml | ||
| cp -R $MESOS_SANDBOX/.ssh $JENKINS_HOME/.ssh | ||
| else | ||
| if [ ! -f $JENKINS_HOME/.USE_PERSISTANT_JENKINS_HOME ]; then |
There was a problem hiding this comment.
This shouldn't be cut-and-paste but a function that can be called. The if/else is a bit confusing as well. Why not use elif?
jbrisbin
reviewed
Jan 10, 2017
| [ | ||
| "hostname", | ||
| "CLUSTER", | ||
| "10.0.24.35" |
There was a problem hiding this comment.
If this is really a template file, hard references here should be replaced with {{host_ip}} or similar.
jbrisbin
reviewed
Jan 10, 2017
| "portMappings": [ | ||
| { | ||
| "containerPort": 8080, | ||
| "hostPort": 31325, |
jbrisbin
reviewed
Jan 10, 2017
| } | ||
| }, | ||
| "env": { | ||
| "JENKINS_CONFIG_REPO": "jbrisbin/jenkins-mesos-softlayer", |
jbrisbin
reviewed
Jan 10, 2017
|
|
||
| sed -i "s#\${JENKINS_CONFIG_REPO}#$JENKINS_CONFIG_REPO#g" $JENKINS_HOME/scm-sync-configuration.xml | ||
| cp -R $MESOS_SANDBOX/.ssh $JENKINS_HOME/.ssh | ||
| if [ "x$USE_PERSISTANT_JENKINS_HOME" == "x" ]; then |
There was a problem hiding this comment.
The correct English spelling is "PERSISTENT".
jbrisbin
reviewed
Jan 10, 2017
| ], | ||
| "fetch": [ | ||
| { | ||
| "uri": "file:///home/jenkins/ssh.tar.gz", |
There was a problem hiding this comment.
The Achille's Heel of this whole thing, IMO. I wish there was a way around this...
yvlasov
force-pushed
the
jenkins-persistant-home
branch
2 times, most recently
from
c23886c to
20780aa
Compare
|
@jbrisbin Hello thank you for comments. It looks like I've fixed issues you mentioned. |
yvlasov
force-pushed
the
jenkins-persistant-home
branch
from
20780aa to
5af9d6b
Compare
yvlasov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.