Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cleanup steps #35

Open
bastienboutonnet opened this issue Nov 7, 2019 · 1 comment
Open

Refactor cleanup steps #35

bastienboutonnet opened this issue Nov 7, 2019 · 1 comment
Labels
status: in progress
Milestone
Objekt

Comments

@bastienboutonnet
Copy link
Owner

Clean up steps do shit like this:
https://github.com/bastienboutonnet/sheetload/blob/d2c302c7cc7d358d2940b636ef109dd41a366739/sheetload/sheetload.py#L86-L90

Thats super bad, ugly and nasty. Need to make it cleaner at some stage
@bastienboutonnet bastienboutonnet added this to the Daft Punk milestone Nov 7, 2019
@bastienboutonnet bastienboutonnet added good first issue 🥇 Good for newcomers help wanted 👋🏻 Extra attention is needed labels Nov 16, 2019
@bastienboutonnet bastienboutonnet removed this from the Daft Punk milestone Dec 27, 2019
@bastienboutonnet bastienboutonnet added this to the Objekt milestone Apr 13, 2020
@bastienboutonnet bastienboutonnet mentioned this issue Apr 27, 2020
Merged
6 tasks
@jflairie
Copy link
Contributor

Adding the ability for the user to configure the cleanup

@bastienboutonnet bastienboutonnet added status: in progress and removed good first issue 🥇 Good for newcomers help wanted 👋🏻 Extra attention is needed labels Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: in progress
Projects
None yet
Milestone
Objekt
Development

No branches or pull requests
2 participants
@bastienboutonnet @jflairie