-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: simplify columns_cleanups using regexs #172
Refactor: simplify columns_cleanups using regexs #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for picking up this issue and cleaning up the part that's supposed to clean the sheet up, but was itself written dirty. Oh the irony!
I really like what you're doing here! I have a few pointers to make things a bit more robust and clearer but you're totally on the right track.
I would suggest you config mypy
and flake8
as your linters so that they will complain when they should. For example the typing issue I brought up would have been flagged. Also, mypy as a linter is super nice!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #35 |
Description
This PR is intended to simplify the cleanup of column names by generating a regular expression based on 2 variables:
_
Note that this PR paves the way for introducing custom cleanup parameters. So next step is to parse new configurations
How has this change been tested?
on ipython with a dummy df
Checklist