Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 disable df casting, drop '' cols from dupe check #206

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

bastienboutonnet
Copy link
Owner

Description

As explained in #204 and #205 pandas data types are a little too shaky at the minute so we're going to disable casting. This is a regression to pre 1.0.0 behaviour but it worked and at least Snowflake is doing a good job of casting dtypes.

How has this change been tested?

functionality removed, unit tests passing

Supporting doc, tickets, issues

Closes #205

@bastienboutonnet bastienboutonnet added this to the Nicolas Jaar milestone Sep 4, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #206 into dev/nicolas_jaar will decrease coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           dev/nicolas_jaar     #206      +/-   ##
====================================================
- Coverage             68.54%   68.17%   -0.37%     
====================================================
  Files                    28       28              
  Lines                  1014      993      -21     
====================================================
- Hits                    695      677      -18     
+ Misses                  319      316       -3     
Flag Coverage Δ
#unittests 68.17% <100.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/adapters/impl.py 29.03% <ø> (-0.66%) ⬇️
setup.py 0.00% <ø> (ø)
core/utils.py 66.10% <100.00%> (-3.35%) ⬇️
tests/test_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1114b95...dc8d44c. Read the comment docs.

@bastienboutonnet bastienboutonnet changed the title fix: 🐛 disable df casting, drop '' cols from dupe cols check fix: 🐛 disable df casting, drop '' cols from dupe check Sep 4, 2020
@bastienboutonnet bastienboutonnet merged commit 9b572ce into dev/nicolas_jaar Sep 4, 2020
@bastienboutonnet bastienboutonnet deleted the fix/empty_column_drop branch September 4, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable df datatype casting for now
1 participant