Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 reintroduce df casting, ignore ints #221

Merged
merged 2 commits into from
Oct 11, 2020

Conversation

bastienboutonnet
Copy link
Owner

@bastienboutonnet bastienboutonnet commented Oct 11, 2020

Description

How has this change been tested?

  • updated unit tests

Supporting doc, tickets, issues

closes #216

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #221 into dev/nicolas_jaar will increase coverage by 0.23%.
The diff coverage is 81.25%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           dev/nicolas_jaar     #221      +/-   ##
====================================================
+ Coverage             67.09%   67.33%   +0.23%     
====================================================
  Files                    24       24              
  Lines                   936      952      +16     
====================================================
+ Hits                    628      641      +13     
- Misses                  308      311       +3     
Flag Coverage Δ
#unittests 67.33% <81.25%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sheetwork/core/adapters/impl.py 32.25% <50.00%> (+0.59%) ⬆️
sheetwork/core/utils.py 69.86% <85.71%> (+3.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6568a...c580607. Read the comment docs.

@bastienboutonnet bastienboutonnet merged commit e0be0d8 into dev/nicolas_jaar Oct 11, 2020
@bastienboutonnet bastienboutonnet deleted the fix/216/turn_on_casting_for_dates branch October 11, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Now that data type casting has been reverted dates don't work well
1 participant