Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] #3471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[email protected] #3471

wants to merge 1 commit into from
+116 −0

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_ros) have been updated in this PR. Please review the changes.

@wep21
Copy link
Contributor

wep21 commented Dec 23, 2024

@meteorcloudy @fmeum Could someone review this PR? cc @mvukov

@hofbi
Copy link
Contributor

hofbi commented Dec 23, 2024

@alexeagle might be also interested in this PR

@alexeagle alexeagle added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 23, 2024
fmeum
fmeum reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red

modules/rules_ros/0.2.0/presubmit.yml
module_path: "examples"
matrix:
platform: ["debian10", "ubuntu2204"]
bazel: ["7.x", "6.x"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bazel: ["7.x", "6.x"]
bazel: ["8.x", "7.x", "6.x"]

@mvukov
Copy link

mvukov commented Dec 24, 2024

Tracking issues in mvukov/rules_ros#100.

@mvukov mvukov mentioned this pull request Dec 24, 2024
Open
@hofbi hofbi mentioned this pull request Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bazel-io @wep21 @hofbi @mvukov @fmeum @alexeagle