Skip to content

Commit

Permalink
Merge pull request #93 from bcgsc/bugfix/KBDEV-1254-new-abstract-clas…
Browse files Browse the repository at this point in the history
…ses-required-admin

bugfix/KBDEV-1254 New Records of Abstract Classes Unnecessarily Required Admin Permission
  • Loading branch information
bnguyen-bcgsc authored Sep 17, 2024
2 parents 8179a92 + 2f205e7 commit 3022954
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/components/QueryResultsTable/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ const QueryResultsTable = ({
<AgGridReact
{...grid.props}
columnDefs={columnDefs}
data={data}
deltaRowDataMode
enableCellTextSelection
frameworkComponents={{ JumpToRecord }}
getRowNodeId={(rowData) => rowData['@rid']}
pagination
paginationAutoPageSize
rowData={data}
suppressHorizontalScroll
/>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/views/ActivityView/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const ActivityView = () => {
}),
]);
const result = [...records, ...edges]
.sort((rec1, rec2) => (rec2.updatedAt || rec2.createdAt) - (rec1.updatedAt || rec1.createdAt));
.sort((rec1: any, rec2: any) => (rec2.updatedAt || rec2.createdAt) - (rec1.updatedAt || rec1.createdAt));
return result;
});

Expand Down Expand Up @@ -133,13 +133,13 @@ const ActivityView = () => {
sortable: true,
},
]}
data={recentRecords}
deltaRowDataMode
enableCellTextSelection
frameworkComponents={{ JumpToRecord }}
getRowNodeId={(data) => data['@rid']}
pagination
paginationAutoPageSize
rowData={recentRecords}
suppressHorizontalScroll
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/views/MainView/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const Main = () => {
})}
{generateAuthenticatedRoutes(['new'], [...ABSTRACT_CLASSES, ...ABSTRACT_CLASSES.map((m) => m.toLowerCase())], {
component: NewRecordSelectView,
admin: true,
admin: false,
})}
<Route element={<AuthenticatedRoute component={NewRecordView} />} path="/new/:modelName" />
<Route element={<AuthenticatedRoute component={DataView} />} path="/data/table" />
Expand Down

0 comments on commit 3022954

Please sign in to comment.