fix: replace auth with simiplier updated solution #23
Conversation
KBDEV-960 was unable to narrow down what was actually causing the infinite redirect loop previously, but replacing it fixed it
|
So overall there are a couple of diff error login states / permission states a user can have.
|
for this case I am going to make a separate ticket since it doesn't actually stop them from logging in (#25) |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## develop #23 +/- ##
===========================================
- Coverage 56.22% 55.85% -0.37%
===========================================
Files 110 108 -2
Lines 4217 4191 -26
Branches 1254 1255 +1
===========================================
- Hits 2371 2341 -30
+ Misses 1579 1576 -3
- Partials 267 274 +7
Continue to review full report at Codecov.
|
in v1 there seems to be a bug where mutate variables are the same as whatever it was called with first in subsequent calls. this is fixed in v2
|
This comment has been minimized.
This comment has been minimized.
this will redirect to login page
you mean an error just for keycloak? I assume this would show on the keycloak login page. if it had an error before the redirect, it would display the error though
displays error
behavior should be unchanged
display error |
This comment has been minimized.
This comment has been minimized.
this is required to get the client working locally. I've targeted develop, but if we want other changes to go into master before develop is merged this should probably target master instead
KBDEV-960
was unable to narrow down what was actually causing the
infinite redirect loop previously,
but replacing it fixed it