Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/KBDEV-1156 Failure to Change User Permissions in Admin #76

Merged
merged 4 commits into from
May 2, 2024

Conversation

bnguyen-bcgsc
Copy link
Contributor

  • Fix bug where admin making adjustments to users result in 'Failed casting email: Buffer is not defined' error
  • Fix random typescript errors
  • Update FormContext and useSchemaForm for consistency of properties

- Update FormContext and useSchemaForm for consistency of properties
@bnguyen-bcgsc bnguyen-bcgsc added the bug Something isn't working label May 2, 2024
@bnguyen-bcgsc bnguyen-bcgsc self-assigned this May 2, 2024

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 56.77%. Comparing base (30f20f7) to head (b062b15).

Files Patch % Lines
...rc/views/AdminView/components/AdminTable/index.tsx 0.00% 6 Missing ⚠️
src/components/FormContext/index.tsx 0.00% 3 Missing ⚠️
src/components/RecordForm/index.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
- Coverage    57.06%   56.77%   -0.29%     
===========================================
  Files          102      102              
  Lines         3852     3854       +2     
  Branches      1297     1299       +2     
===========================================
- Hits          2198     2188      -10     
- Misses        1642     1654      +12     
  Partials        12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

@bnguyen-bcgsc bnguyen-bcgsc merged commit b89f8a2 into develop May 2, 2024
3 checks passed
Copy link

github-actions bot commented May 2, 2024

Unit Test Results

    1 files  ±0    39 suites  ±0   1m 37s ⏱️ -2s
160 tests ±0  160 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
156 runs  ±0  156 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b89f8a2. ± Comparison against base commit 30f20f7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants