Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client v4.3.1 Patch Release #91

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Client v4.3.1 Patch Release #91

merged 6 commits into from
Sep 12, 2024

Conversation

bnguyen-bcgsc
Copy link
Contributor

Release Notes - Knowledge Base development - Version client v4.3.1

Bug

  • [KBDEV-1249] - Unable to add variant record to Graphkb

bnguyen-bcgsc and others added 6 commits September 11, 2024 14:03
- Add check if variant has positional information before transforming refSeq and refAA for protein position
- Undo ternary operator for api response for variant creation/update to get result data for snackbar and redirecting to variant view
…without-positional-info

bugfix/KBDEV-1249 Unable to Add New Variant Without Positional Information
@bnguyen-bcgsc bnguyen-bcgsc added the release Release PR. Should contain the version increment and putative release notes as the description label Sep 12, 2024
@bnguyen-bcgsc bnguyen-bcgsc self-assigned this Sep 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.76%. Comparing base (057d2b7) to head (e8a760c).

Files with missing lines Patch % Lines
src/components/VariantForm/index.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   56.77%   56.76%   -0.02%     
==========================================
  Files         102      102              
  Lines        3873     3874       +1     
  Branches     1311     1310       -1     
==========================================
  Hits         2199     2199              
- Misses       1662     1663       +1     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnguyen-bcgsc bnguyen-bcgsc merged commit c4b6118 into master Sep 12, 2024
3 checks passed
Copy link

Unit Test Results

    1 files  ±0    39 suites  ±0   1m 37s ⏱️ ±0s
160 tests ±0  159 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
156 runs  ±0  155 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit c4b6118. ± Comparison against base commit 057d2b7.

@bnguyen-bcgsc bnguyen-bcgsc changed the title Client v4.30.1 Patch Release Client v4.3.1 Patch Release Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release PR. Should contain the version increment and putative release notes as the description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants