Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TMB Signature CategoryVariant matching #51

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mathieulemieux
Copy link
Member

The goal is to match to either 'high mutation burden high signature' or 'mutation burden high signature' for now, until we fix the data to use 'mutation burden high signature' only.

What a KbMatches record looks like before/after:

# before
{
  "kbVariant": "high mutation burden high signature",
  "variant": "high mutation burden",
  "variantType": "tmb",
  "kbVariantId": "#161:920"
}

# after
{
  "kbVariant": "high mutation burden high signature",
  "variant": "mutation burden high signature",
  "variantType": "tmb",
  "kbVariantId": "#161:920"
}

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 86.11%. Comparing base (bc5e679) to head (c9d6c66).

Files with missing lines Patch % Lines
pori_python/ipr/main.py 11.11% 8 Missing ⚠️
pori_python/ipr/annotate.py 20.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (29.41%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #51      +/-   ##
===========================================
- Coverage    86.14%   86.11%   -0.03%     
===========================================
  Files           18       18              
  Lines         2410     2412       +2     
===========================================
+ Hits          2076     2077       +1     
- Misses         334      335       +1     
Flag Coverage Δ
unittests 86.11% <29.41%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathieulemieux
Copy link
Member Author

Tested on POG2021 (high tmb) with both current and develop branch, with one 'mutation burden ' statement on graphkbdev and all 'high mutation burden' statements on graphkbstaging. All behaviors seems as expected.

@mathieulemieux mathieulemieux self-assigned this Mar 18, 2025
@mathieulemieux
Copy link
Member Author

Passes integration tests as well

@mathieulemieux mathieulemieux marked this pull request as ready for review March 18, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants