Check for config #1142
Closed
Check for config #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (fs == sdName && !config->_sdCard->is_configured(out)) { | ||
| return Error::InvalidStatement; | ||
| } | ||
|
|
There was a problem hiding this comment.
Another reason for putting the check in FluidPath is that the fs argument to renameObject and friends is just the default, which can be overridden with an explicit prefix like /localfs/ or /sd/ . Thus checking based on fs == sdName will fail to catch some uses of SD, and will wrongly complain if the sd default is overridden via an explicit /localfs/ prefix in the parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a config error and message if not configured.