GSoC Warm Up Kernel Task #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartkopp/can-isotp@ced84ca Signed-off-by: Robert Nelson <[email protected]>
Signed-off-by: Robert Nelson <[email protected]>
…all-multi-tce for DDW" This reverts commit c4faf62.
This reverts commit 2875109.
patch-5.4.19-rt11.patch.xz Signed-off-by: Robert Nelson <[email protected]>
https://git.zx2c4.com/WireGuard/commit/edad0d6e99e5133b1e8e865d727a25fff6399cb4 Signed-off-by: Robert Nelson <[email protected]>
Reference: v5.6-rc5 Signed-off-by: Robert Nelson <[email protected]>
Reference: v5.5.8 Signed-off-by: Robert Nelson <[email protected]>
Signed-off-by: Robert Nelson <[email protected]>
Signed-off-by: Robert Nelson <[email protected]>
5.4.20-ti-rt-r6 bb.org_defconfig 5.4 TI Delta: RobertCNelson/ti-linux-kernel@68481af...738552d BBDTBS: beagleboard/BeagleBoard-DeviceTrees@cffe558 CAN-ISOTP: hartkopp/can-isotp@ced84ca RT: patch-5.4.19-rt11.patch.xz TI_AMX3_CM3: http://git.ti.com/gitweb/?p=processor-firmware/ti-amx3-cm3-pm-firmware.git;a=commit;h=6a849767df85ce9399494f53fb5c753665396653 WIREGUARD: https://git.zx2c4.com/WireGuard/commit/edad0d6e99e5133b1e8e865d727a25fff6399cb4 Signed-off-by: Robert Nelson <[email protected]>
dlech
reviewed
May 31, 2020
| config GSOC_DUMMY_CHAR_DEVICE | ||
| tristate "GSoC Warmup Driver" | ||
| help | ||
| This builds the GSoC Dummy Char Driver, which is required for the warmup task. |
There was a problem hiding this comment.
Help lines should be indented with 1 tab + 2 spaces
drivers/char/Kconfig
Outdated
| only mixes the entropy pool. |
There was a problem hiding this comment.
Watch out for unintentional changes like editors that automatically add a newline at the end of the file.
| * Dummy character driver by | ||
| * John Madieu <[email protected]> | ||
| * | ||
| * This program is free software; you can redistribute it and/or |
There was a problem hiding this comment.
Using SPDX license identifier is used nowdays instead of license paragraphs.
https://www.kernel.org/doc/html/latest/process/license-rules.html
| #include <linux/cdev.h> | ||
| #include <linux/uaccess.h> | ||
|
|
||
| static int gsoc_char_dev_open(struct inode * inode, struct file * file); |
There was a problem hiding this comment.
It probably depends on the area of the kernel but most code I have seen tries to avoid forward declarations if possible by rearranging the code.
| // register a range of char dev numbers 0 to 1 in this case | ||
| err = alloc_chrdev_region(&gsoc_dev, 0, 1, "gsoc_dummy_char_dev"); | ||
| if (err < 0) { | ||
| pr_err("Can't get major number\n"); |
There was a problem hiding this comment.
It is a good idea to include the module name in the error message so users know which module the error came from.
| static ssize_t gsoc_char_dev_read(struct file *file, char __user * buf, size_t count, | ||
| loff_t * offset) | ||
| { | ||
| pr_info("Read function of GSoC dummy driver called.\n"); |
There was a problem hiding this comment.
It could be fun to actually put something in the buffer so that you can actually read something from the character device.
|
Hey David, thank you very much for these helpful tricks. Best, |
RobertCNelson
force-pushed
the
5.4-rt
branch
2 times, most recently
from
326b612 to
aaaf846
Compare
RobertCNelson
force-pushed
the
5.4-rt
branch
2 times, most recently
from
44ff8bd to
9cf53b3
Compare
RobertCNelson
force-pushed
the
5.4-rt
branch
from
b533d1d to
36e5010
Compare
RobertCNelson
force-pushed
the
5.4-rt
branch
2 times, most recently
from
681c6fa to
3fef3b8
Compare
RobertCNelson
force-pushed
the
5.4-rt
branch
2 times, most recently
from
dd2e1d9 to
b687de1
Compare
RobertCNelson
force-pushed
the
5.4-rt
branch
3 times, most recently
from
a0eb9c6 to
f1d27f8
Compare
RobertCNelson
force-pushed
the
5.4-rt
branch
2 times, most recently
from
1296885 to
1ec7015
Compare
RobertCNelson
force-pushed
the
5.4-rt
branch
2 times, most recently
from
35c83cd to
99cce5a
Compare
RobertCNelson
force-pushed
the
5.4-rt
branch
from
3ab269b to
5f60de4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request for Media Ip Streaming project, which implements a dummy kernel driver for the GSoC 2020 warm up task.