Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses: astral-sh/ruff-action@v3 #224

Closed
wants to merge 2 commits into from
Closed

Conversation

cclauss
Copy link

@cclauss cclauss commented Jan 16, 2025

https://github.com/astral-sh/ruff-action

Ruff is written in Rust so it does not require any particular version of Python.

astral-sh/ruff-action@v3https://github.com/astral-sh/ruff-action

Ruff is written in Rust so it does not require any particular version of Python.
@dnicolodi
Copy link
Collaborator

Thanks, using the action is maybe nicer than installing ruff via pip, except that IIUC the action defaults to annotating the patch using ruff's github output format. I'm not a fan of having automated tools spam the PRs with annotations that often make it harder to focus on the review comements from humans.

However, the main question is: why? I'm a bit surprised by a passing by contribution touching the CI setup of a project. I start to be suspicious when the commit message for the patch is badly worded and formatted. What did prompt this patch?

@cclauss
Copy link
Author

cclauss commented Jan 20, 2025

the action defaults to annotating the patch using ruff's github output format

I made a second commit which should undo that default. I have never heard objections to GitHub Annotations but everyone has unique impressions.

a passing by contribution touching the CI setup of a project.

I am learning how folks use ruff so I read GitHub Actions that use it and suggest optimizations when I see opportunities.

What did prompt this patch?

beanquery was added to homebrew so the repo caught my attention. I apologize if my commit message is cryptic.

@cclauss cclauss closed this Jan 20, 2025
@cclauss cclauss deleted the patch-1 branch January 20, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants