Implement ANY and ALL #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
arrays2
branch
15 times, most recently
from
3179422 to
953daef
Compare
Add "accounts" to the "entries", "postings", and "transactions" tables.
And use types.name() everywhere.
This deviates from the "||" operator used in standard SQL, but it is both easier to implement and more natural in a Python environment.
It works like the regular expression match operator "~" but with the arguments in the reversed order (to make it more useful in combination with the ALL and ANY operators). Furthermore, it does not default to case insensitive matching. The regular expression inline flag (?i) can be used to perform case insensitive matching. This does not follow the SQL standard nor there is precedent for it in any SQL-like query language that I know of. The operator name is not set in stone and can be adapted to any prior art.
The AST is rewritten to contain an explicit reference to the accounts column. This removes the need to pass the current row object (which is of the expected kind only when iterating the postings or entries tables) to the function evaluation. This removes the last function implementation that uses the current row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.