Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lumen example app #3

Merged
merged 6 commits into from
Apr 15, 2019
Merged

Add lumen example app #3

merged 6 commits into from
Apr 15, 2019

Conversation

erifili117
Copy link

added . files

Update composer.json

Fix for folder rename in composer

Rename to PYR

Pyr prefix and grouping

Change in description

Fix redis prefix change

restore history fixes

Fix for env vars on start/stop commands

Readme modifications

@erifili117 erifili117 requested review from dbaltas and gpapadopg April 12, 2019 13:41
added . files

Update composer.json

Fix for folder rename in composer

Rename to PYR

Pyr prefix and grouping

Change in description

Fix redis prefix change

restore history fixes

Fix for env vars on start/stop commands

Readme modifications
@erifili117 erifili117 force-pushed the example-application branch from d5e0190 to 138268b Compare April 12, 2019 13:51
gpapadopg
gpapadopg previously approved these changes Apr 12, 2019
Copy link

@dbaltas dbaltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an emphasized link in the main readme towards the examples/lumen_app.
Also, have some screenshots from grafana in the examples/lumen-app readme.
We can address this in another PR though.

@erifili117 erifili117 force-pushed the example-application branch from 1dc264d to c46f204 Compare April 12, 2019 15:35
dbaltas
dbaltas previously approved these changes Apr 12, 2019
Copy link

@dbaltas dbaltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erifili117
Copy link
Author

Notice!! Images are not available due to pointing to the master branch. When the PR gets merged they should be visible. Otherwise we could merge the images first and then the rest of the changes.

@erifili117 erifili117 dismissed stale reviews from dbaltas and gpapadopg via c281243 April 14, 2019 19:23
Copy link

@dbaltas dbaltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erifili117 erifili117 requested a review from gpapadopg April 15, 2019 07:12
@erifili117 erifili117 merged commit 8322a09 into master Apr 15, 2019
@erifili117 erifili117 deleted the example-application branch April 15, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants