Only remove the unescape prefix character when parsing #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently the `unescape_formulas` option when parsing will remove any first character of a cell as long as the second character is part of the `@escape_formula_start`. This causes issues when the data is something like this: ``` "A-1","B+2","C=3","'@d" ``` which should parse to this: ``` ["A-1", "B+2", "C=3", "@d"] ``` but parses to this instead: ``` ["-1", "+2", "=3", "@d"] ``` This change will check that the first character is actually the escape character we want before removing it. * Slight fix up of the documentation
|
The failing tests doesn't seem to be related to my change and I can't figure out how to kick it off again. Any ideas @beatrichartz ? |
|
Looking good, merged. Thanks! |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses
Currently the
unescape_formulasoption when parsing will remove any first character of a cell as long as the second character is part of the@escape_formula_start. This causes issues when the data is something like this:"A-1","B+2","C=3","'@D"which should parse to this:
["A-1", "B+2", "C=3", "@D"]but parses to this instead:
["-1", "+2", "=3", "@D"]This change will check that the first character is actually the escape character we want before removing it.
Slight fix up of the documentation