-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python in CI #5544
Update python in CI #5544
Conversation
I commented under your previous PR with an explanation what happened - total bamboozle on my end. |
I'm thinking maybe we should comment out 3.13 and 3.14 for now with a note that this depends on |
Unfortunately new version of |
Why would dropping 3.9 be a problem?
So, it seems dropping 3.9 should not be a problem today. Would you agree? |
Historically, beets has never dropped support for a non-EOL Python version. If we do so, those people that use Python 3.9 will be forced to upgrade their setups early in order to upgrade beets, which is not ideal. People have various legitimate reasons for using the earliest support Python: for example, maintaining their own open-source packages. I checked monthly beets download for each Python version: Seems like there's still a considerable number of people who use it with Python 3.9 :) |
the assumption, though, is that all those users are on the latest version of beets/ Is that the case? Also, how are those statistics fetched? I was not aware that beets has a telemetry that was able to provide such info, was I under the wrong assumption os are those from somewhere else? |
That's just download statistics from pypi, see pypistats. I can see on pepy.stats that nearly all users download the most recent version indeed. |
I see, thanks! |
Most likely this is going to happen with EOL of Python 3.9. We should support 3.11 and 3.12 anyways though! |
@Fale Would you be happy to remove 3.13 and 3.14 for now and rebase on master so that we can merge this in? Otherwise, I could take it from here myself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI configuration to support multiple and current Python versions while introducing an experimental matrix for testing newer Python releases.
- Updated the Python version matrix to include versions 3.10, 3.11, and 3.12.
- Added experimental entries for Python 3.13 and 3.14-dev with conditional error continuation.
- Included additional package dependencies (llvm, libopenblas-dev) in the CI install step.
Comments suppressed due to low confidence (2)
.github/workflows/ci.yaml:27
- Using 'continue-on-error' conditioned on 'matrix.experimental' will suppress job failures for experimental configurations. Please confirm that this behavior is intended to avoid masking real issues in experimental runs.
continue-on-error: ${{ matrix.experimental }}
.github/workflows/ci.yaml:23
- The inclusion of the experimental Python version '3.14-dev' may require additional test coverage to ensure compatibility. Please verify and add tests if needed to cover potential issues with this version.
- python-version: "3.14-dev"
Should be ok now :) |
Thank you! |
Description
Bump python version in the CI to current versions.
This is the same as #5503 that for some reason got closed when the merge of the
drop-py38
branch happened