-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbsync: add timid flag #5600
base: master
Are you sure you want to change the base?
mbsync: add timid flag #5600
Conversation
@Duncaen this looks pretty straightforward, and I'll look at it soon. Can you provide an example in action in the meantime before I try it out myself - just for a high-level usability check? |
At the moment its just the normal
|
Could you rebase your branch on top of the most recent master please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new --timid flag to the mbsync command to prompt users for confirmation before applying changes. Key changes include:
- Adding the -t/--timid option to the command-line parser.
- Updating the function signatures of both singletons and albums to accept the timid parameter.
- Incorporating interactive confirmation logic based on the timid flag.
Files not reviewed (2)
- docs/changelog.rst: Language not supported
- docs/plugins/mbsync.rst: Language not supported
Comments suppressed due to low confidence (1)
beetsplug/mbsync.py:118
- The timid flag functionality is new and currently lacks tests. Please add tests to ensure that interactive confirmations work as expected in both singletons and albums flows.
if timid:
Description
Fixes #4250. Adds the
--timid
flag to thembsync
command/plugin.To Do