FIX: Dereference symlinks before hardlinking #5684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a hardlink, either during import or
beet convert, if the origin of the hardlink was a symlink, that symlink used to be directly copied. This could create broken symlinks if the origin symlink was relative, and in either case, probably wasn't the user's desired behavior.This change de-references all symlinks before creating a hardlink, such that the end result is a normal file with the same inode as the original file. See #5676 for more discussion about the original issue.
Fixes #5676
Documentation(N/A)