BUG: Wrong path edited when running config -e #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously: ALWAYS edited the default config path Corrected: When the --config <path> option is used, that path is edited
Alch-Emi
force-pushed
the
edit-custom-config
branch
from
434280e to
4a43191
Compare
|
Oops, I thought I checked that. (force-push to fix formatting) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #5652,
beet --config <path> config -eedited the default config path, even though that's not the config that would be used by beets.It seems like this was the result of a deliberate short-circuit in
_raw_main(). The short-circuit prevents malformed configs from causing a crash before opening the editor, but also prevents the setup function from loading the custom config at all.The solution used here is to just expose the CLI options to
edit_config(), so that it can use the custom config path if its set. I also suspect that the branch inconfig_func()which is getting short circuited is actually unreachable, but I left it in with a note just in case.Fixes #5652
To Do
Documentation(N/A)