Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pip usage and notarization logging. #2149

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

freakboy3742
Copy link
Member

Fixes 2 small issues:

  1. Removes the use of the --no-python-version-warning. pip 25.0 displays the following warning if it is used:
DEPRECATION: --no-python-version-warning is deprecated. pip 25.1 will enforce this behaviour change. A possible replacement is to remove the flag as it's a no-op. Discussion can be found at https://github.com/pypa/pip/issues/13154
  1. Adds quiet=1 to two uses of parse_output in the notarization code. When we introduced Surface raw errors when check_output fails #2125, we added quiet=1 to all uses of check_output() where a error code was normal expected operation, and added a call to output_error() if the error received wasn't an expected value. We audited the code for all check_output() calls... but forgot that parse_output() builds on check_output(). The notarisation code includes 2 such uses; there are no others that I can find.

Given the 25.1 release could happen at any time, it may be advisable to push out a new release after merging this PR. The quiet=1 fix isn't a major issue, but it would be nice to clean up at the same time.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith February 6, 2025 06:23
Copy link
Member

@mhsmith mhsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip 25.1 will enforce this behaviour change

I've asked them about the fact that this appears to be earlier than their deprecation policy allows.

Given the 25.1 release could happen at any time

It looks like they still have a long list in the milestone, so it probably isn't imminent.

@mhsmith mhsmith merged commit 90448eb into beeware:main Feb 6, 2025
57 checks passed
@freakboy3742 freakboy3742 deleted the misc-cleanup branch February 6, 2025 23:38
@freakboy3742
Copy link
Member Author

Given the 25.1 release could happen at any time

It looks like they still have a long list in the milestone, so it probably isn't imminent.

True - but given we're prone to months between releases, it would be easy to be bitten by pip releasing before our own informal release process decides it's time for 0.3.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants