Correct pip usage and notarization logging. #2149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2 small issues:
--no-python-version-warning
. pip 25.0 displays the following warning if it is used:quiet=1
to two uses ofparse_output
in the notarization code. When we introduced Surface raw errors when check_output fails #2125, we addedquiet=1
to all uses ofcheck_output()
where a error code was normal expected operation, and added a call tooutput_error()
if the error received wasn't an expected value. We audited the code for allcheck_output()
calls... but forgot thatparse_output()
builds oncheck_output()
. The notarisation code includes 2 such uses; there are no others that I can find.Given the 25.1 release could happen at any time, it may be advisable to push out a new release after merging this PR. The quiet=1 fix isn't a major issue, but it would be nice to clean up at the same time.
PR Checklist: