Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for librosa 0.10.1 #41

Closed

Conversation

noelmullankuzhy
Copy link
Contributor

Added recipe for librosa 0.10.1

librosa was not part of the supported recipes

Terminal Output Librosa Build Success.txt

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@noelmullankuzhy
Copy link
Contributor Author

noelmullankuzhy commented Mar 15, 2024

I am not sure whether this can be considered as build success unless all the dependencies of this library are built successfully too. Please advice.

@noelmullankuzhy noelmullankuzhy deleted the add_librosa_recipe branch March 15, 2024 13:00
@noelmullankuzhy noelmullankuzhy restored the add_librosa_recipe branch March 15, 2024 13:00
@mhsmith
Copy link
Member

mhsmith commented Mar 15, 2024

As I said in #37, librosa is a pure-Python package, so it doesn't need a recipe. Once all of its native dependencies have been built (most notably Numba), the existing wheel on PyPI can be used directly.

@mhsmith mhsmith closed this Mar 15, 2024
@noelmullankuzhy
Copy link
Contributor Author

Please help me out here. I am trying to understand how to add requirements the meta.yaml. This is what I understand so far.

The following is pulled from setup.cgf of librosa.

install_requires =
    audioread >= 2.1.9
    numpy >= 1.20.3, != 1.22.0, != 1.22.1, != 1.22.2
    scipy >= 1.2.0
    scikit-learn >= 0.20.0
    joblib >= 0.14
    decorator >= 4.3.0
    numba >= 0.51.0
    soundfile >= 0.12.1
    pooch >= 1.0
    soxr >= 0.3.2
    typing_extensions >= 4.1.1
    lazy_loader >= 0.1
    msgpack >= 1.0

These should be added to the host subsection of the requirements section in meta.yaml

And the following is pulled from pyproject.toml of librosa.

requires = [
    "setuptools >= 48",
    "wheel >= 0.29.0",
]

These should be added to the build subsection of the requirements section in meta.yaml

@mhsmith
Copy link
Member

mhsmith commented Mar 15, 2024

No, you don't need to build librosa at all, because it has a none-any wheel on its PyPI page, meaning it's compatible with any platform. But to use librosa you will need iOS wheels for all of the packages in the install_requires list which don't have none-any wheels on PyPI, and possibly some indirect requirements as well.

Some of these requirements are already in the BeeWare repository, such as NumPy; others already have issues on this tracker, such as SciPy (#10).

@noelmullankuzhy
Copy link
Contributor Author

That you for the detailed explanation. My understanding about this was wrong since I am new to this project.

@noelmullankuzhy noelmullankuzhy deleted the add_librosa_recipe branch April 29, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants