New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HashEnricher config optional #157

Open

maxtheaxe wants to merge 1 commit into bellingcat:main from maxtheaxe:optional-hash-config

maxtheaxe commented Dec 3, 2024

Fixes #156. The same concept could be applied to Step itself, by updating __init__() with something like the following.

if config:
    for k, v in config.get(self.name, {}).items():
        self.__setattr__(k, v)
else: # allow initialization with default values
    for k, v in self.configs():
        self.__setattr__(k, v)

I wasn't sure of your preferences, so I figured I'd only add it where necessary for the time being, though I'm happy to refactor it.


          make HashEnricher config optional

889446c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet